Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kubeadm's bootstrap token types #5425

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use kubeadm's bootstrap token types #5425

wants to merge 1 commit into from
+136 −169

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jan 9, 2025

Description

Kubeadm has proper types for bootstrap tokens. Use those types instead of the current ad-hoc solution. This includes the token generation, which had a bias for certain values before.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 force-pushed the use-kubeadm-bootstrap-token branch 2 times, most recently from 937a7ce to e7ebff1 Compare January 10, 2025 14:08
@twz123
Use kubeadm's bootstrap token types
be96a3a 
Kubeadm has proper types for bootstrap tokens. Use those types instead
of the current ad-hoc solution. This includes the token generation,
which had a bias for certain values before.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 force-pushed the use-kubeadm-bootstrap-token branch from e7ebff1 to be96a3a Compare January 10, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@twz123